Skip to content

CLI MVP#284

Merged
jirhiker merged 21 commits into
stagingfrom
jir-cli-photo
Dec 12, 2025
Merged

CLI MVP#284
jirhiker merged 21 commits into
stagingfrom
jir-cli-photo

Conversation

@jirhiker

@jirhiker jirhiker commented Dec 10, 2025

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Want to give the developers and tool set to add data to data system

How

Implementation summary - the following was changed / added / removed:

  • use click
  • abstract out service/logic layer so that both interfaces (API, CLI) can use it

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@codecov-commenter

codecov-commenter commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.81560% with 40 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/water_level_csv.py 83.09% 35 Missing ⚠️
services/gcs_helper.py 76.92% 3 Missing ⚠️
api/observation.py 84.61% 2 Missing ⚠️
Files with missing lines Coverage Δ
schemas/water_level_csv.py 100.00% <100.00%> (ø)
tests/test_observation.py 94.68% <100.00%> (+0.54%) ⬆️
api/observation.py 93.44% <84.61%> (-2.56%) ⬇️
services/gcs_helper.py 73.68% <76.92%> (+0.09%) ⬆️
services/water_level_csv.py 83.09% <83.09%> (ø)

@jirhiker jirhiker changed the title Jir cli photo CLI MVP Dec 11, 2025
jacob-a-brown
jacob-a-brown reviewed Dec 11, 2025
View reviewed changes
Comment thread services/asset_helper.py
Comment thread cli/service_adapter.py Outdated
Comment thread tests/features/cli-associate-assets.feature
Comment thread cli/service_adapter.py
Comment thread tests/features/data/asset_import_batch/manifest.txt
Comment thread tests/features/steps/cli-associate-assets.py
@chasetmartin chasetmartin mentioned this pull request Dec 11, 2025
Closed
@jirhiker

jirhiker commented Dec 12, 2025

Copy link
Copy Markdown
Member Author

@jacob-a-brown this PR is getting too large. I suggest it be merged in staging and then open smaller PRs to address outstanding issues

@jirhiker jirhiker merged commit 7739391 into staging Dec 12, 2025
6 checks passed
@jirhiker jirhiker deleted the jir-cli-photo branch March 12, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob-a-brown jacob-a-brown jacob-a-brown left review comments
@ksmuczynski ksmuczynski Awaiting requested review from ksmuczynski
@chasetmartin chasetmartin Awaiting requested review from chasetmartin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jirhiker @codecov-commenter @jacob-a-brown @chasetmartin